fix: example update secret tagging #491

alienzach · 2025-09-16T15:20:49Z

TL;DR

Updated model references from gpt-4.1 to gpt-5 and removed commented-out developer secret references.

What changed?

Changed the default OpenAI model from gpt-4.1 to gpt-5 in both the config file and the main.py script
Removed commented-out developer secret references in the example secret files
Added commented-out temporal configuration section for cloud deployment with timeout settings
Cleaned up the example secret files by removing redundant commented lines

How to test?

Verify that the model references in mcp_agent.config.yaml and main.py are correctly updated to gpt-5
Ensure the example secret files still contain the necessary configuration structure
Check that the added temporal configuration section is properly formatted and commented out

Why make this change?

This change updates the model references to use the latest GPT model and simplifies the example configuration files by removing unnecessary commented-out developer secret references. The added temporal configuration section provides guidance for users who need to adjust timeout settings for cloud deployments.

Summary by CodeRabbit

New Features
- Added an optional (commented) cloud deployment configuration block to support timeout, host, and task queue settings.
Chores
- Upgraded the default model in the workflow evaluator/optimizer example to gpt-5.
Documentation
- Cleaned up example secrets by removing outdated commented placeholders and guidance lines.
- Clarified example configuration for Anthropic by using a plain api_key placeholder.
- Improved comments describing optional cloud deployment settings.

coderabbitai · 2025-09-16T15:20:56Z

Walkthrough

This PR updates example configs and code: removes commented secret placeholders in two secrets templates, switches example/model settings from gpt-4.1 to gpt-5 in one workflow, and adds a commented optional temporal deployment block to a workflow config. No control-flow or API surface changes.

Changes

Cohort / File(s)	Summary
Workflow Evaluator Optimizer: Code and config updates `examples/workflows/workflow_evaluator_optimizer/main.py`, `examples/workflows/workflow_evaluator_optimizer/mcp_agent.config.yaml`	Bumped model from gpt-4.1 to gpt-5 in code and OpenAI default model; added a commented optional temporal block (timeout_seconds, host, task_queue).
Secrets examples cleanup `examples/usecases/mcp_github_to_slack_agent/mcp_agent.secrets.yaml.example`, `examples/workflows/workflow_evaluator_optimizer/mcp_agent.secrets.yaml.example`	Removed commented developer-secret guidance lines; in the GitHub-to-Slack example, replaced Anthropic commented secret with a plain placeholder api_key line.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: upgrade gh-slack example for cloud #464 — Also edits the GitHub-to-Slack secrets example around Slack/GitHub/Anthropic auth fields.
feat: improve optimizer evaluator workflow for cloud #425 — Prior change to the same workflow’s model selection in main.py (to gpt-4.1), related to this PR’s bump to gpt-5.

Suggested reviewers

saqadri
andrew-lastmile

Poem

A rabbit tweaks the keys by night,
Swaps models swift, keeps configs light.
Secrets whispered, comments trimmed,
Temporal dreams left softly primmed.
Thump-thump! The workflow’s set to thrive—
Carrots up, gpt-5!
Hop on—deploy arrives.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "fix: example update secret tagging" is concise and clearly describes the removal/adjustment of commented secret references in the example files, which is a visible and relevant part of this changeset. It does not call out the model bump to gpt-5 or the added commented temporal config, but it is specific and informative enough for a quick scan.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 09-16-fix_example_update_secret_tagging

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

alienzach · 2025-09-16T15:21:05Z

fix: example update secret tagging #491 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

examples/usecases/mcp_github_to_slack_agent/mcp_agent.secrets.yaml.example (1)
19-20: Add placeholder warning — do not commit real Anthropic API keys.

examples/usecases/mcp_github_to_slack_agent/mcp_agent.secrets.yaml.example (lines 19–20): anthropic.api_key is consumed by the config loader/tests; replace the plaintext placeholder with a non-secret placeholder and a one-line warning.
anthropic:
-  api_key: your-anthropic-api-key
+  # Placeholder only. Do NOT commit real secrets; use env injection or your secrets manager.
+  api_key: "YOUR_ANTHROPIC_API_KEY"

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 875152f and c09eba0.

📒 Files selected for processing (4)

examples/usecases/mcp_github_to_slack_agent/mcp_agent.secrets.yaml.example (1 hunks)
examples/workflows/workflow_evaluator_optimizer/main.py (1 hunks)
examples/workflows/workflow_evaluator_optimizer/mcp_agent.config.yaml (2 hunks)
examples/workflows/workflow_evaluator_optimizer/mcp_agent.secrets.yaml.example (0 hunks)

💤 Files with no reviewable changes (1)

examples/workflows/workflow_evaluator_optimizer/mcp_agent.secrets.yaml.example

🧰 Additional context used

🧬 Code graph analysis (1)

examples/workflows/workflow_evaluator_optimizer/main.py (1)

src/mcp_agent/workflows/llm/augmented_llm.py (1)

RequestParams (124-174)

🔇 Additional comments (3)

examples/workflows/workflow_evaluator_optimizer/mcp_agent.config.yaml (2)

39-39: OpenAI default_model set to "gpt-5" — canonical ID confirmed (gpt-5, verified 2025-09-16); add runtime fallback

Official model ID: "gpt-5" (OpenAI docs, verified Sep 16, 2025).

Occurrences: examples/workflows/workflow_evaluator_optimizer/mcp_agent.config.yaml:39; examples/basic/mcp_basic_agent/mcp_agent.config.yaml:24; examples/workflows/workflow_evaluator_optimizer/main.py:81.

Action: validate model access at startup or catch API errors and fall back to a configurable alternative (e.g., gpt-4.1) to avoid runtime failures.

6-10: Verified — temporal block supported; default timeout = 60s

TemporalSettings exists in the schema (top-level "temporal", $defs.TemporalSettings) with required host and task_queue and timeout_seconds default 60; src/mcp_agent/config.py also defaults timeout_seconds=60. The commented example is fine — if you uncomment it you must supply host and task_queue.
examples/workflows/workflow_evaluator_optimizer/main.py (1)
79-82: Prefer the configured default model instead of hardcoding "gpt-5"

If this example isn't intentionally demonstrating a per-call override, remove the explicit model so RequestParams() inherits the app config default. Per-call overrides are supported across examples/tests, but unable to find evidence in the repo that openai.default_model is set to "gpt-5" — confirm config if you rely on that.

File: examples/workflows/workflow_evaluator_optimizer/main.py:79-82
       request_params=RequestParams(model="gpt-5"),
       request_params=RequestParams(),

fix: example update secret tagging

c09eba0

alienzach marked this pull request as ready for review September 16, 2025 15:21

alienzach requested review from andrew-lastmile, rholinshead and saqadri September 16, 2025 15:22

rholinshead approved these changes Sep 16, 2025

View reviewed changes

coderabbitai bot reviewed Sep 16, 2025

View reviewed changes

alienzach merged commit 135cc95 into main Sep 16, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: example update secret tagging #491

fix: example update secret tagging #491

Uh oh!

alienzach commented Sep 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

alienzach commented Sep 16, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: example update secret tagging #491

fix: example update secret tagging #491

Uh oh!

Conversation

alienzach commented Sep 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TL;DR

What changed?

How to test?

Why make this change?

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

alienzach commented Sep 16, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alienzach commented Sep 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 16, 2025 •

edited

Loading